Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript definition is not available to use on npm module #73

Closed
mitsuruog opened this issue May 30, 2019 · 1 comment
Closed

TypeScript definition is not available to use on npm module #73

mitsuruog opened this issue May 30, 2019 · 1 comment

Comments

@mitsuruog
Copy link
Contributor

@igorfv

Related: feat: Add TypeScript typings #66

I tried version 2.3.0 via npm, but the Typings file doesn't appear.
Could you change the build process somethings to copy the Typings file to lib folder?
(I didn't notice build process at that time, sorry)

Thanks.
@AnandChowdhary
Copy link

Yes, the types are part of the master branch, but looks like they're not in the 2.3.0 release:

This should be in this folder; https://unpkg.com/parse-domain@2.3.0/lib/

@jhnns jhnns closed this as completed in 8173362 Jun 14, 2019
jhnns added a commit that referenced this issue Jun 14, 2019
@jhnns
fix: TypeScript definition not available on npm module
711b199 
Fixes #73
jhnns added a commit that referenced this issue Jun 14, 2019
@jhnns
fix: TypeScript definition not available on npm module
2f4684c 
Fixes #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitsuruog @AnandChowdhary