Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign every place a country code #16

Open
missinglink opened this issue Jul 11, 2019 · 0 comments
Open

Assign every place a country code #16

missinglink opened this issue Jul 11, 2019 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@missinglink
Copy link
Member

missinglink commented Jul 11, 2019

It would be ideal if each source dataset contained the ISO country-code for each place, unfortunately, this is rare.

This issue is to investigate a method of ensuring that each place is associated with an ISO code at import-time.

One way this could be achieved is to enforce hierarchies for each place and use that to find the country.

Another way would be to PIP each place as it's imported, but this comes with the complexity of requiring countries (and dependencies) to be imported prior to other data.

We could also consider relaxing the requirement to say that the country code is allowed to be NULL during import but is computed later, after all the data imported via a post-processing script. -it depends on how we intend to use it.

Some advantages to having mandatory country codes:

  • Issues like Improved place ontology #4 can be resolved
  • Fast filtering and searching per-country
  • Easy to cut regional extracts from a planet database
  • etc.

We would also need to develop a convention for places for which an ISO code is not relevant, just as: ocean, continent, planet

@missinglink missinglink added enhancement New feature or request question Further information is requested labels Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant