Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build error on main due to tokio 1.21.0 unstable feature #1355

Closed
redshiftzero opened this issue Sep 2, 2022 · 3 comments · Fixed by #1358
Closed

build error on main due to tokio 1.21.0 unstable feature #1355

redshiftzero opened this issue Sep 2, 2022 · 3 comments · Fixed by #1358

Comments

@redshiftzero
Copy link
Member

Build error just occurred on main when I merged #1328, probably unrelated?

err:    Compiling console-subscriber v0.1.7
err: error[E0308]: mismatched types
err:     --> /***/.cargo/registry/src/github.com-1ecc6299db9ec823/console-subscriber-0.1.7/src/lib.rs:1066:12
err:      |
err: 1061 | ) -> tokio::task::JoinHandle<T>
err:      |      -------------------------- expected `tokio::task::JoinHandle<T>` because of return type
err: ...
err: 1066 |     return tokio::task::Builder::new().name(_name).spawn(task);
err:      |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `tokio::task::JoinHandle`, found enum `Result`
err:      |
err:      = note: expected struct `tokio::task::JoinHandle<_>`
err:                   found enum `Result<tokio::task::JoinHandle<_>, std::io::Error>`
err: 
err: For more information about this error, try `rustc --explain E0308`.
err: error: could not compile `console-subscriber` due to previous error
err: warning: build failed, waiting for other jobs to finish...
err: error: build failed
@redshiftzero
Copy link
Member Author

Hypothesis: this is due to release of tokio 1.21.0 in the last 24 hours (https://github.com/tokio-rs/tokio/releases/tag/tokio-1.21.0) which includes tokio-rs/tokio#4823

@hdevalence
Copy link
Member

That looks right, seems like it should be an easy fix to patch our use of the API?

@redshiftzero redshiftzero changed the title build error on main build error on main due to tokio 1.21.0 unstable feature Sep 2, 2022
@redshiftzero
Copy link
Member Author

Cross linking tokio-rs/console#373

There are also some related build errors in our view crate which we can fix, though the console-subscriber API change we'll need updated, so in #1358 I'm gonna pin us to the old version for now

redshiftzero added a commit that referenced this issue Sep 6, 2022
There's a new release of console-subscriber including
#1355
but this only works with tokio 1.21.0
redshiftzero added a commit that referenced this issue Sep 6, 2022
* doc updates for 028-harpalyke

* allocations and updated discord addresses for 028-harpalyke

* pin console-subscriber to 0.1.7

There's a new release of console-subscriber including
#1355
but this only works with tokio 1.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants