Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav background during page-to-page transitions should not change #50

Open
domyen opened this issue Oct 25, 2014 · 4 comments
Open

Nav background during page-to-page transitions should not change #50

domyen opened this issue Oct 25, 2014 · 4 comments

Comments

@domyen
Copy link
Member

domyen commented Oct 25, 2014

When navigating to a new page, the nav's white background disappears as the new page is sliding into view. The white background should remain the same throughout the entire transition.

@tmeasday
Copy link
Member

@dominicnguyen - the reason here is that we were doing something wacky in doing a waypoint on the scrollable div. You are supposed to do the way point on the thing that's moving within the scrollable div.

Check out my fix. Better ideas?

@tmeasday tmeasday added the fixed label Oct 27, 2014
@tmeasday tmeasday assigned domyen and unassigned tmeasday Oct 27, 2014
@tmeasday
Copy link
Member

Note if you want to mess with this that you should be able to call $.waypoints('refresh'); without negative side-effects.

@domyen
Copy link
Member Author

domyen commented Oct 27, 2014

Hey T, the fix solves my interaction concern. Why .children().first()?

@tmeasday
Copy link
Member

Well like I said we need a child of a scrollable div to attach the waypoint to. That seemed the best way to get one

On 27 Oct 2014, at 6:46 pm, Dominic Nguyen notifications@github.com wrote:

Hey T, the fix solves my interaction concern. Why .children().first()?


Reply to this email directly or view it on GitHub.

@domyen domyen removed their assignment Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants