Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version strings #12

Open
aramk opened this issue Sep 1, 2014 · 3 comments
Open

Version strings #12

aramk opened this issue Sep 1, 2014 · 3 comments

Comments

@aramk
Copy link

aramk commented Sep 1, 2014

Could support be added for version strings with various formats? The most common is major.minor.increment. We could provide an option for which to use, or a comparator function to determine the correct ordering.

@zol
Copy link
Member

zol commented Sep 1, 2014

@aramk - Good idea. Right now you're free to use any numbering scheme you want but of course the ordering probably won't be right. I'll add a configuration option for a sort comparator and hopefully this will work solve your use case.

@zol zol added the enhancement label Sep 1, 2014
@jakobdamjensen
Copy link

or just use timestamps like Rails.. Would make it easie in team where people do migrations on their own branches..

@zol you say we can use any scheme we want.. but they have to follow each other right? So we can't go from 4 to 6 right? Else timestamps would work right now.. I'm right about that assumption.. right? =)

@zol
Copy link
Member

zol commented Apr 15, 2015

@jakobdamjensen they don't have to follow each other. They will be ordered by this line: https://github.com/percolatestudio/meteor-migrations/blob/master/migrations_server.js#L62 so timestamps will work fine right now if that is how you want to organize your migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants