Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v2.0 #87

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Release v2.0 #87

wants to merge 15 commits into from

Conversation

StorytellerCZ
Copy link
Collaborator

@StorytellerCZ StorytellerCZ commented May 22, 2023 •
edited

Move to async and minimum Meteor version is 2.8

Incorporates #86

@StorytellerCZ StorytellerCZ linked an issue May 22, 2023 that may be closed by this pull request
Migrate to async (Meteor 2.8 and onwards) #84
Open
@Grubba27
Copy link
Collaborator

The ci is failing

Grubba27
Grubba27 reviewed May 23, 2023
View reviewed changes
package.js
@@ -1,14 +1,14 @@
Package.describe({
summary: 'Define and run db migrations.',
version: '1.1.0',
version: '2.0.0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may break things but I agree on the changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this update is necessary as the internals will change significantly and there will be hard minimum Meteor requirement of 2.8.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can either release the full version or if you want @Grubba27 we can release a beta. Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe release a beta?

migrations_server.js Outdated Show resolved Hide resolved
@StorytellerCZ
Copy link
Collaborator Author

@Grubba27 tests passing now, but I'm seeing a few UnhandledPromiseRejectionWarning which we need to find and fix.

@StorytellerCZ StorytellerCZ marked this pull request as ready for review August 23, 2023 08:50
@StorytellerCZ
Copy link
Collaborator Author

Fixed all the tests. I would like to release a alpha/beta so that it can be tested by more people.

Grubba27
Grubba27 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@Grubba27 Grubba27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick review, LGTM, but, I think we should release a beta and then v2.

@StorytellerCZ
Copy link
Collaborator Author

Yes, I'm thinking that we should have alpha versions and so on to track with the Meteor 3 alpha releases as well.

@Grubba27
Copy link
Collaborator

Yes, I'm thinking that we should have alpha versions and so on to track with the Meteor 3 alpha releases as well.

Agreed but at the same time someone who is in the v2.x track could migrate to 2.0 in this package

@StorytellerCZ
Copy link
Collaborator Author

Yes, I'm thinking that we should have alpha versions and so on to track with the Meteor 3 alpha releases as well.

Agreed but at the same time someone who is in the v2.x track could migrate to 2.0 in this package

I don't follow. My idea is to release 2.0-alpha.1 of this package that will also include in versionsFrom: 3.0-alpha.11 and then release additional alphas together with any fixes or releases in the Meteor 3.0 alphas/betas. This way we can test things on Meteor 2.0 and 3.0 together with the changes that have been made. I'm using similar approach with other packages.

@StorytellerCZ StorytellerCZ mentioned this pull request Sep 28, 2023
Open
@dallman2
Copy link

dallman2 commented Feb 6, 2024

When will this be merged into the production version of this package? I'm looking forward to testing the changes:)

@StorytellerCZ
Copy link
Collaborator Author

@Grubba27 could you make a beta release please?

@kolyasya
Copy link

@StorytellerCZ @Grubba27 waiting for this to be merged 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grubba27 Grubba27 Grubba27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to async (Meteor 2.8 and onwards)
4 participants
@StorytellerCZ @Grubba27 @dallman2 @kolyasya