Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blog] Back button from blog/contact takes you back two #32

Open
tmeasday opened this issue Feb 24, 2015 · 6 comments
Open

[blog] Back button from blog/contact takes you back two #32

tmeasday opened this issue Feb 24, 2015 · 6 comments
Labels
bugs

Comments

@tmeasday
Copy link
Member

I guess the contact form isn't writing to history on the blog?
@tmeasday tmeasday added the bugs label Feb 24, 2015
@zol
Copy link
Member

zol commented Feb 24, 2015

@tmeasday how is this supposed to work on the blog? On ps.com client side routing takes care of this for us however on the blog we don't use a client side router so whilst unexpected what happens is technically correct. Whats your suggestion?

@zol zol assigned tmeasday and unassigned zol Feb 24, 2015
@tmeasday
Copy link
Member Author

@zol - I'm not totally sure. We could do a simple implementation of browser.location.hash = 'contact' and use onhashchange to detect the back click. Not sure it's worth the added complexity however.

@zol
Copy link
Member

zol commented Feb 25, 2015

I'm inclined to live with this for the time being. I wouldn't classify it as a critical bug.

@tmeasday
Copy link
Member Author

Fine by me.

@tmeasday
Copy link
Member Author

Oh, perhaps check out this commit: 7c7de24

@domyen
Copy link
Member

domyen commented Feb 27, 2015

@tmeasday can we apply the same technique for the blog? I'd be in favor of that.

@tmeasday tmeasday assigned zol and unassigned tmeasday Mar 4, 2015
@zol zol changed the title Back button from blog/contact takes you back two [blog[ Back button from blog/contact takes you back two Mar 4, 2015
@zol zol changed the title [blog[ Back button from blog/contact takes you back two [blog] Back button from blog/contact takes you back two Mar 4, 2015
@zol zol removed their assignment Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zol @tmeasday @domyen