Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product: First and last products should have larger adjacent images #6

Open
domyen opened this issue Jan 31, 2015 · 7 comments
Open

Comments

@domyen
Copy link
Member

domyen commented Jan 31, 2015

If you navigate to the first and last products in an index, their adjacent products in the index (the ones at the very bottom of the page) in this case the single adjacent product should use the larger sized image and be wider.

We solve this in the blog with php logic that reads like this:

if there is a previous post AND a next post
  show previous and next post
else
  if there is a previous post
    show previous post
  else
    show next post
  endif
endif

What is the logic for handlebars?

Screenshot of first product in index' adjacent post:
screenshot 2015-01-31 12 45 16

@tmeasday
Copy link
Member

tmeasday commented Feb 1, 2015

You'll see the parent div (.collage) has class .single in this case. Do we need more than this?

@tmeasday tmeasday assigned domyen and unassigned tmeasday Feb 1, 2015
@domyen
Copy link
Member Author

domyen commented Feb 2, 2015

We need to be able to change out the image so it doesn't load the lower quality asset.

domyen pushed a commit that referenced this issue Feb 2, 2015
@domyen domyen added the fixed label Feb 2, 2015
@domyen domyen assigned zol and unassigned domyen Feb 2, 2015
@zol
Copy link
Member

zol commented Feb 4, 2015

Looks good!

@zol zol closed this as completed Feb 4, 2015
@domyen domyen reopened this Feb 27, 2015
@domyen
Copy link
Member Author

domyen commented Feb 27, 2015

@tmeasday we had this working in the previous version; when there is only one adjacent post, the background image should be the featureUrl.

@domyen domyen removed the fixed label Feb 27, 2015
@domyen domyen assigned tmeasday and unassigned zol Feb 27, 2015
@tmeasday tmeasday added the fixed label Mar 4, 2015
@tmeasday
Copy link
Member

tmeasday commented Mar 4, 2015

Can you check if the picture polyfill is working too? Esp on changing routes.

@tmeasday tmeasday assigned domyen and unassigned tmeasday Mar 4, 2015
@domyen
Copy link
Member Author

domyen commented Mar 4, 2015

@tmeasday when the image is by itself and large, shrinking the viewport to mobile size should change the source to the smaller sized thumbnail.

Repro:

  1. http://localhost:3000/what/campus
  2. Go to bottom of the page
  3. The image will be large
  4. Resize viewport to mobile size
  5. The image should change to the thumbnail

@domyen domyen removed the fixed label Mar 4, 2015
@domyen domyen assigned tmeasday and unassigned domyen Mar 4, 2015
@tmeasday
Copy link
Member

tmeasday commented Mar 5, 2015

I think this is sorted now. Bear with me @dominicnguyen ;)

@tmeasday tmeasday added the fixed label Mar 5, 2015
@tmeasday tmeasday removed their assignment Mar 5, 2015
@domyen domyen removed their assignment Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants