fix: parsing glob strings #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
force-pushed
the
ww/parse-globs
branch
from
7cf17b0
to
2dfa572
Compare
|
🏁 I manually finalized the Percy build |
djones
pushed a commit
that referenced
this pull request
Oct 28, 2019
## [0.19.3](v0.19.2...v0.19.3) (2019-10-28) ### Bug Fixes * parsing glob strings ([#404](#404)) ([d52e552](d52e552))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When passing a comma-separated list of globs, sometimes spaces might appear after commas causing the globs to start or end with a space.
I also noticed that valid globs with comma separated lists (commonly used for extensions) would be split incorrectly. i.e.
**/*.{html,htm}and**/*.{png,jpg,jpeg}Fixes #311
Approach
Created a common
parseGlobsconfiguration utility that splits a comma-separated string, while preserving glob lists within{...}, and trims whitespace from glob patterns. It also performs the duty of filtering out empty strings.The configuration unit tests were nested so this could be tested without the extra hooks used in the other config tests.