Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TaskCloseable implement AutoCloseable directly #207

Open
carl-mastrangelo opened this issue Mar 11, 2023 · 2 comments
Open

Make TaskCloseable implement AutoCloseable directly #207

carl-mastrangelo opened this issue Mar 11, 2023 · 2 comments
Labels
Version 1.0 Changes For the Next Version

Comments

@carl-mastrangelo
Copy link
Member

Currently it extends Closeable directly but that's due to being stuck on Java 6.
@carl-mastrangelo carl-mastrangelo added the Version 1.0 Changes For the Next Version label Mar 11, 2023
@szarnekow
Copy link

Since this now requires Java 8, AutoClosable is an option, isn't it?

@carl-mastrangelo
Copy link
Member Author

Yes. I think this may be safe to change, but I would need to think more about this. I had keo StringFunction around due to ABI compatibility, but I dont think anyone access that type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Version 1.0 Changes For the Next Version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szarnekow @carl-mastrangelo