Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring whether thread renames should be respected or make perfmark more scalable #33

Open
aktau opened this issue Feb 11, 2020 · 0 comments

Comments

@aktau
Copy link

aktau commented Feb 11, 2020

We'd like to trace execution of RPCs on our frontend using perfmark.

For debugging purposes, our frontend renames a thread when work is scheduled on it. When the task starts executing, it looks at certain important fields and puts it in the thread name. This is to aid debugging when the process crashes. It allows trivially identifying which requests were running when the server died.

Right now, perfmark creates a new "row" whenever this happens. Sadly, this soon leads to an inability to load the traces in the browser as there will be too many threads.

A couple of options:

  • A configuration option to make perfmark ignore thread renames somehow.
  • A configuration option (or trace display option) to limit the history of traces. I believe that in any given 1 minute window there's not likely to have been too many threads active.
  • Something else...?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant