Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mu): duplicate From-Process tags on transactions #660

Closed
VinceJuliano opened this issue May 1, 2024 · 1 comment · Fixed by #735
Closed

fix(mu): duplicate From-Process tags on transactions #660

VinceJuliano opened this issue May 1, 2024 · 1 comment · Fixed by #735
Assignees

Comments

@VinceJuliano
Copy link
Collaborator

VinceJuliano commented May 1, 2024

Either Messages coming in from users and coming out of process results have been reported to have duplicate From-Process tags there should only be one on each message. We should check both.

Tags in the MU are added in the build-tx.js function. It may be that these duplicates are coming from aoconnect though and not the MU.

@VinceJuliano VinceJuliano self-assigned this May 1, 2024
@VinceJuliano VinceJuliano mentioned this issue May 1, 2024
10 tasks
@jfrain99 jfrain99 self-assigned this May 23, 2024
@jfrain99
Copy link
Contributor

Build-tx is already filtering out duplicate From-Process tags, since it is manually assigned the fromProcessId. Added a test to ensure duplicate input From-Process tags results in one output From-Process tags.
Connect sends duplicates if specified by user - could be patched, but seems to be non-issue.

jfrain99 added a commit that referenced this issue May 24, 2024
fix(mu): handle duplicate from-process tags on transactions #660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants