Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies - Broadcaster Postgres dependency problem #57

Open
operatorequals opened this issue Apr 1, 2023 · 1 comment
Open

Comments

@operatorequals
Copy link

Hello people!
First and foremost, I really appreciate your project! I am also using it heavily in a library I am making - eventhive.

So, I am trying to use your fastapi PubSub in a project that cannot use compiled C extensions.

This wouldn't be a problem as fastapi is Python, but broadcaster does require a postgres dependency that contains C code, failing my build.

I propose to create optional dependencies, exactly like broadcaster does, so I can exclude the postgres dependency that creates the issue - I'm not planning to use postgres anyway!

Thanks again for your project, it really is very useful!

@operatorequals operatorequals changed the title Broadcaster Postgres dependency Optional dependency - Broadcaster Postgres dependency problem Apr 1, 2023
@operatorequals operatorequals changed the title Optional dependency - Broadcaster Postgres dependency problem Optional dependencies - Broadcaster Postgres dependency problem Apr 1, 2023
@orweis
Copy link
Contributor

orweis commented Apr 2, 2023

HI @operatorequals :)
Thanks for reaching out and for the kind words :)
Eventhive sounds cool, and I'm happy our Pub/Sub impl. helps you there.

Sure, you can go ahead an open a PR to have that as part of the setup.py / requirements.txt ; please include a "default" or "all" option that will install all the dependencies as now, and one for each of the potential targets (e.g. postgres, redis, ... )

@roekatz or I will review and approve :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants