Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive<RetryableQuery> never assigns the return value from IncrementFailures() and your job will never finish. #217

Open
arbesoft opened this issue May 26, 2017 · 0 comments

Comments

@arbesoft
Copy link

you have to replace line 197 in https://github.com/petabridge/akka-bootcamp/blob/master/src/Unit-3/lesson5/Completed/Actors/GithubCoordinatorActor.cs with

**Receive(query => !query.CanRetry && query.Query is GithubWorkerActor.QueryStarrer, query =>
{
_githubProgressStats = _githubProgressStats.IncrementFailures();

            foreach (var subscriber in _subscribers)
            {
                subscriber.Tell(_githubProgressStats);
            }
        });**

because if you get an error for example from git the error I have listed below. The Job never will finish, the expecteduser never will be the same like UsersThusFar + QueryFailures. If you not assign the return value from "IncrementFailures" the QueryFailures always will be ZERO.

{
"documentation_url": "https://developer.github.com/v3/#abuse-rate-limits",
"message": "You have triggered an abuse detection mechanism. Please wait a few minutes before you try again."
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant