Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP page #12

Open
PeeHaa opened this issue Jan 13, 2014 · 3 comments
Open

PHP page #12

PeeHaa opened this issue Jan 13, 2014 · 3 comments

Comments

@PeeHaa
Copy link

PeeHaa commented Jan 13, 2014

I just checked the PHP page of this thing.

Imho explanation is too much lacking. So the people who need this site will have no use for it at all in its current state.

They will simply look at it and think "why would I need that simply to get the attribute of my div??" and continue using their crappy regex patterns.

Same goes for libxml_use_internal_errors(true);. People have no idea what it does and how to use it. So they either try removing it and are hit by errors or they just leave it in place (or use it from now on everytime they need to parse html).

However because the error state is never reset in the example code this may very well result in a genuine WTF when people are trying to debug code.

@petdance
Copy link
Owner

I agree, it's lacking. It would be great if you could help provide some additions to the page.

@PeeHaa
Copy link
Author

PeeHaa commented Jan 14, 2014

Can I simply edit the MD and send over a PR?

(No promises, but I at least want to fix the errors state flag)

@petdance
Copy link
Owner

Yes, that would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants