Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Can no longer retrieve None without raw=True #167

Open
NovaNekmit opened this issue Jun 30, 2021 · 1 comment
Open

[Regression] Can no longer retrieve None without raw=True #167

NovaNekmit opened this issue Jun 30, 2021 · 1 comment

Comments

@NovaNekmit
Copy link

NovaNekmit commented Jun 30, 2021

It used to work with a previous version, but doesn't work anymore.

None can still be put inside, but getting it out (without raw) will get stuck ie here.

Not sure what would be best, there are couple options:

  • Use an exception instead of "special return values" to signal no object
  • Use an unique object internally in place of None, ie NO_OBJECT = object()
  • Add raw=False to put and raise an warning when None inside unless it is set (to notify developers)
  • Leave as is and hope developers notice this API change and find out to use raw by themselves
@NovaNekmit NovaNekmit changed the title [Regression] Can no longer retrieve None [Regression] Can no longer retrieve None without raw=True Jun 30, 2021
@peter-wangxu
Copy link
Owner

I personally prefer not adding the None into the queue since the None itself may cause other issue inside the queue implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants