Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request to at least 2.54.0 to support NO_PROXY #54

Closed
fjakop opened this issue Feb 10, 2016 · 1 comment
Closed

Update request to at least 2.54.0 to support NO_PROXY #54

fjakop opened this issue Feb 10, 2016 · 1 comment

Comments

@fjakop
Copy link

fjakop commented Feb 10, 2016

Pleas upgrade the dependency request to a version >= 2.54.0. Since this version it honors the env variable NO_PROXY, so we can disable the proxy for testing purposes, like tests with nock.
@Powersource
Copy link
Contributor

This looks to be fixed https://github.com/peterbraden/ical.js/blame/master/package.json#L18

But I'm having this issue request/request#2040
I'm gonna try to fix this tomorrow.

@Powersource Powersource mentioned this issue Oct 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fjakop @Powersource