Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not create extensions.idx if no extensions exist #508

Closed
decebals opened this issue Oct 26, 2022 · 0 comments
Closed

Not create extensions.idx if no extensions exist #508

decebals opened this issue Oct 26, 2022 · 0 comments
Assignees
@decebals

Comments

@decebals
Copy link
Member

For more context see #449 (comment).
@decebals decebals self-assigned this Oct 26, 2022
dbyron-sf pushed a commit to dbyron-sf/kork that referenced this issue Feb 20, 2024
@dbyron-sf
chore(dependencies): upgrade pf4j from 3.2.0 to 3.10.0 to resolve CVE…
e8c82dd 
…-2023-40828

pf4j 3.10.0 brings in slf4j-api 2.0.6 which is not compatible with logback 1.2.x.
Upgrading logback created incompatibility issues with Springboot's LogbackLoggingSystem.

> Task :kork-tomcat:test

com.netflix.spinnaker.kork.tomcat.CRLFHeaderTest > clientTest() FAILED
    java.lang.NoClassDefFoundError at LogbackLoggingSystem.java:293
        Caused by: java.lang.ClassNotFoundException at BuiltinClassLoader.java:581

1 test completed, 1 failed
        Caused by: java.lang.ClassNotFoundException at BuiltinClassLoader.java:581

So, pin slf4j-api to 1.7.36 to retain compatibility with logback to 1.2.x.

Removed a test(extensions index is written to META-INF) from TestPluginGeneratorTest.kt as the upgraded pf4j no longer create extensions.idx if no extensions exist.(refer pf4j/pf4j#508)

Note: PluginWrapper is deprecated in 3.10.0 and will be removed in the next major release as per this - pf4j/pf4j#512. So next pf4j upgrade would break the functionality of existing plugins.
@dbyron-sf dbyron-sf mentioned this issue Feb 20, 2024
Merged
mergify bot added a commit to spinnaker/kork that referenced this issue Feb 20, 2024
@dbyron-sf @jasonmcintosh @mergify
chore(dependencies): upgrade pf4j from 3.2.0 to 3.10.0 to resolve CVE…
42d2de6 
…-2023-40828 (#1153)

pf4j 3.10.0 brings in slf4j-api 2.0.6 which is not compatible with logback 1.2.x.
Upgrading logback created incompatibility issues with Springboot's LogbackLoggingSystem.

> Task :kork-tomcat:test

com.netflix.spinnaker.kork.tomcat.CRLFHeaderTest > clientTest() FAILED
    java.lang.NoClassDefFoundError at LogbackLoggingSystem.java:293
        Caused by: java.lang.ClassNotFoundException at BuiltinClassLoader.java:581

1 test completed, 1 failed
        Caused by: java.lang.ClassNotFoundException at BuiltinClassLoader.java:581

So, pin slf4j-api to 1.7.36 to retain compatibility with logback to 1.2.x.

Removed a test(extensions index is written to META-INF) from TestPluginGeneratorTest.kt as the upgraded pf4j no longer create extensions.idx if no extensions exist.(refer pf4j/pf4j#508)

Note: PluginWrapper is deprecated in 3.10.0 and will be removed in the next major release as per this - pf4j/pf4j#512. So next pf4j upgrade would break the functionality of existing plugins.

Co-authored-by: Kiran Godishala <k.godishala@salesforce.com>
Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decebals decebals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@decebals