New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobInputStream should implement skip #3144
Comments
Thanks for the suggestion. |
I don't see any existing tests for the class. |
I guess we do not have specific tests for The mix of |
You have implemented |
In fact, the current implementation of mark/reset is tested in |
Using seek is more efficient than reading and discarding the bytes. The only behavioural change is it now allows skipping past the natural end of the stream, but the method contract already allows for this. It should not break anything. Closes pgjdbc#3144
Using seek is more efficient than reading and discarding the bytes. The only behavioural change is it now allows skipping past the natural end of the stream, but the method contract already allows for this. It should not break anything. Closes pgjdbc#3144
Using seek is more efficient than reading and discarding the bytes. The only behavioural change is it now allows skipping past the natural end of the stream, but the method contract already allows for this. It should not break anything. Closes pgjdbc#3144
Using seek is more efficient than reading and discarding the bytes. The only behavioural change is it now allows skipping past the natural end of the stream, but the method contract already allows for this. It should not break anything. Closes pgjdbc#3144
Describe the issue
InputStream
has methodsskip(long)
andskipNBytes(long)
, which by default read and discard the given number of bytes.BlobInputStream
should instead override this to callLargeObject.seek64
, which will give better performance.Driver Version?
42.7.2
The text was updated successfully, but these errors were encountered: