Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Netty 5 #553

Open
hantsy opened this issue Oct 16, 2022 · 4 comments
Open

Upgrade to Netty 5 #553

hantsy opened this issue Oct 16, 2022 · 4 comments
Labels
type: dependency-upgrade A dependency upgrade type: enhancement A general enhancement
Milestone

Comments

@hantsy
Copy link

hantsy commented Oct 16, 2022

I found r2dbc-postgresql depends on Netty 4.x.

In Spring 6, it added optional Netty 5 as runtime, when use Netty 5 to build a Spring WebFlux project and use R2dbc/Postgres, then in the project dependencies, Netty4 and Netty 5 coexist in the same application.

Is it possible adding Reactor Netty 5 support in this R2dbc driver. Mark io.projectreactor.netty:reactor-netty and io.projectreactor.netty:reactor-netty5 as optional, detect it in the classpath to select one.

@hantsy hantsy added the type: enhancement A general enhancement label Oct 16, 2022
@linghengqian
Copy link

  • Personally, I hope that we will continue to maintain the minimum JDK compilation version as JDK8 until reactor-core mentions its minimum JDK compilation version to JDK11. Importing Netty 5 seems to complicate things.

@mp911de
Copy link
Collaborator

mp911de commented Oct 25, 2022

We don't have an adoption timeline for Netty 4 yet. R2DBC intentionally remains with a low baseline to enable reactive database connectivity for applications that are required to remain on Java 8. With the extended support of Java 8 until 2030, there's no urgency for us to break compatibility.

We expect the Reactor Netty library for Netty to be supported for at least another 3 to 4 years. We could imagine a switch to Netty 4 for an R2DBC Postgres 2.0 major upgrade. However, with 1.0 not having yet released 1.0.0.RELEASE, we don't even need to discuss timelines for 2.0.

@mp911de mp911de changed the title Update to Netty 5? Upgrade to Netty 5 Oct 25, 2022
@mp911de mp911de added the type: dependency-upgrade A dependency upgrade label Oct 25, 2022
@mp911de mp911de added this to the 2.0 Backlog milestone Oct 25, 2022
@hantsy
Copy link
Author

hantsy commented Oct 25, 2022

Ok, in one word, is it possible to add reactor-netty5(which depends on Netty 5) support and align with the new Netty 5 adoption in Spring 6?

@Squiry
Copy link
Collaborator

Squiry commented Oct 25, 2022

IIRC netty 5 has another interface for buffers, so we will have to rewrite like the whole encoding/decoding layer, so no, it doesn't sound as a drop in replacement yet it is quite possible and will be done somewhere in a future anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants