Add support for PHP 7

[lukaszwit]

Please add support for PHP 7 (RC now and stable in future)

[naxhh]

I'll wait for stable.. it should be soon!

[HMAZonderland]

PHP7 is to be expected november 26; https://wiki.php.net/todo/php70#timetable

[gustavoper]

We hope so!

http://news.php.net/php.internals/89100

[khromov]

👍

[v2p]

Good news everyone :) It seems that PHP 7 is released. http://php.net/archive/2015.php#id2015-12-03-1

[naxhh]

Yep! it's out.

PR's are welcome, as always.

Ondrej has the ppa out already: https://launchpad.net/~ondrej/+archive/ubuntu/php-7.0

So, should be as easy as adding it to the ui
https://github.com/phansible/role-php/blob/master/tasks/main.yml#L4
https://github.com/phansible/phansible/blob/master/src/Phansible/Resources/views/bundles/languages/php.html.twig#L16

Removing 5.4 would be nice too.

Also keep in care extensions:
https://github.com/phansible/phansible/blob/master/src/Phansible/Roles/Php.php

[popstas]

Hello, I'm trying to add PHP 7 support, please review my dirty implementation
I made depedent php modules completion and corrected modules names for database connectors.

What about role-php, I'm going to introduce variables {{php.version}} (php5 or php7.0) and {{php.config_prefix}} (/etc/php5 or /etc/php/7.0).

If all right, I will do it in next week and make PR.

[popstas]

I rewrited role-php, please review commit. After some testing found that other roles also hardcoded php5: role-nginx, role-xdebug.

For nginx role I appended condition for correct php-fpm socket path, see commit

And I disabled xdebug selection for php 7.0 because xdebug 2.4 for php 7.0 was not released yet.

[khromov]

@popstas Maybe you should open a PR for this? That way we can discuss it in the PR. 👍

[naxhh]

@popstas: As @khromov said you should open a PR. Is much easier for us to review code.
Does not matter if it's a "dirty" implementation or is not 100% working yet. At least we can start improving it (if required) from there :)

Thanks for taking the time to make this happen.

[popstas]

@naxhh, I opened pull requests and make CI checks passed.

[naxhh]

As I said, thanks!

ping @phansible/core-dev for reviews.

[debo]

@naxhh @popstas I added a little comment in the role PR but overall it looks good to me so far

[khromov]

What's the status of PHP 7 support in Phansible? phansible/role-php#7 seems to be merged, is #264 still required?

You aren't currently able to use PHP 7 when going to http://phansible.com/

[naxhh]

#264 is pending for testing.

Because of personal stuff I will not be able to test this (or anything on phansible) until 20 of March.
Debo is currently leading PR's. But will be nice if someone can help him.

Testing that should be done:

• You should not be able to choose php 5.4 in phansible
• Php 5.5 should still work
• Php 5.6 should still work
• When you are on 5.5/5.6 php packages should be all php5-
• When you are on php 7 php packages should be all php7-
• You should be able to install php 7
• You should be able to make php 7 work with apache
• You should be able to make php 7 work with nginx

As you can see. There's a lot of stuff to test. That's why takes a while to me to go throw all the PR's
If you make some of this test. Please post the results here and when all are done I'll merge & deploy php7 support.

[debo]

@khromov @popstas @naxhh sorry for the late reply, I'm going to review this over the weekend and merge it if everything is working fine. Promise.

[topikito]

+1
Awesome, subscribing myself so I get notified when @debo finishes the review

[HMAZonderland]

Hows the review going?

[debo]

@HMAZonderland is going slow because I was and still am in the middle of a house moving, I'm trying my best to move this forward as fast as possible though, I didn't forget, especially because I need this too :)

[Caroga]

any updates on the matter?

[debo]

@Caroga I do apologies for the time is taking me to promote all these updates but I am in the middle of an international relocation so I didn't have much time to focus on the project. I will do my best. Thanks for the understanding.

[Caroga]

No need to apologize. Is there anything we might be able to help you with on this matter?

[HMAZonderland]

@Caroga you can perform these tests #250 (comment)

[Caroga]

Will take a look at it tomorrow!

[floodedcodeboy]

Okay so I've taken the liberty of grabbing a copy of #264 and going through the following test cases :

Test Cases

• You should not be able to choose php 5.4 in phansible 👍
• PHP5.5 should still work 👎
  • PHP5.5 (PHP Version 5.5.9-1ubuntu4.20) works with apache
  • PHP5.5 works with nginx
  • BUGS
    • php_packages NEEDS to be referenced as "{{ php_packages }}" however when this is fixed the provisioning works.
• Php 5.6 should still work
  • php5.6 works with apache 👎
  • BUGS
    • PHP 5.6.28-1+deb.sury.org~trusty+1 installed on cli
    • PHP Version 5.5.9-1ubuntu4.20 (fpm) installed to apache
  • php5.6 works with nginx 👎
  • BUGS
    • PHP 5.6.28-1+deb.sury.org~trusty+1 installed on cli
    • PHP on nginx does not work out the box
• When you are on 5.5/5.6 php packages should be all php5- 👍
• When you are on php 7 php packages should be all php7- 👍
• You should be able to install php 7 🎱
• You should be able to make php 7 work with apache 🎱
• You should be able to make php 7 work with nginx 🎱

Bugs

• Vagrant up throws errors on provisioning due to the way sys_packages, php_packages are referenced and the PPA is not referenced correctly. Please pull in Correct PPA location and corrected the way php_packages and sys_packages is referenced #291

I'll update these as I knock them off... if there's a better place to put this - please let me know.

[floodedcodeboy]

Okay - so I'm going to stop there. This PR is nowhere near ready. Sorry folks :(

You can find the files I used for testing (generated by the PR #264 ) here: #264 (comment)

[naxhh]

@floodedcodeboy thanks for taking your time to do these testings ;)

[floodedcodeboy]

@naxhh not a problem - very happy to help out on this project - it's something I use daily and have until recently tried to convert people to use. I clearly have a personal interest :D

hopefully it helps move thing forward ;)