From 50613e8014a938b54c6d36f52a16a104ee62015e Mon Sep 17 00:00:00 2001 From: zepumph Date: Thu, 7 Nov 2019 13:51:16 -0900 Subject: [PATCH] add no-multi-assign-on-declaration lint rule, https://github.com/phetsims/chipper/issues/794 --- js/PhetMenu.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/PhetMenu.js b/js/PhetMenu.js index 6cc0417f..36d6df0a 100644 --- a/js/PhetMenu.js +++ b/js/PhetMenu.js @@ -365,8 +365,7 @@ define( require => { const maxTextHeight = _.maxBy( textNodes, function( node ) {return node.height;} ).height; // Create the menu items. - const items = this.items = _.map( keepItemDescriptors, function( itemDescriptor ) { - + const items = _.map( keepItemDescriptors, function( itemDescriptor ) { const menuItemOptions = { textFill: itemDescriptor.textFill, checkedProperty: itemDescriptor.checkedProperty, @@ -397,6 +396,7 @@ define( require => { ); } ); + this.items = items; const separatorWidth = _.maxBy( items, function( item ) {return item.width;} ).width; const itemHeight = _.maxBy( items, function( item ) {return item.height;} ).height;