New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt user to save their work when they click the "Back to {locale} {locale-code} Sim List" link #341
Comments
Add prompt to save when user clicks the "Back to {locale} {locale-code} Sim List" button. See #341. Part of phetsims/qa#869.
I'm not sure if this is worth the extra effort and complexity it would introduce. I think it could be done, but it would involve some hackery to make the links work. I think we'd need to add an |
Since fc6c136 covers the original request, I'm going to mark this as ready for review. |
@jbphet and I discussed this. Since the That being said, eventually we want to have a proper prompt that asks the user to save before they leave if the form is dirty with respect to the database and dirty with respect to the saved translation in phetsims/babel. |
See #341. Specifically, see #341 (comment). This came out of phetsims/qa#869.
Add prompt to save when user clicks the "Back to {locale} {locale-code} Sim List" button. See #341. Part of phetsims/qa#869.
See #341. Specifically, see #341 (comment). This came out of phetsims/qa#869.
There is another issue for this #325. |
In phetsims/qa#869, @solaolateju noted that it would be a good idea to prompt the user to save their work if they click the "Back to {Locale} {locale-code}" link. We already have plans to warn the user to save their work if they are about to navigate away from the page in #325, but as a temporary measure, I think it would be a good idea to prompt the user to save if they click the "Back to {Locale} {locale-code}" link.
We might also be able to prompt them if they click the "Select Locale" link in the nav if we check the URL to verify they are on the translation form page.
When we do #325, we'll want to remove these warnings because they will be redundant.
The text was updated successfully, but these errors were encountered: