Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How come this repo doesn't dogfood its own runners in its github actions ? #930

Closed
nitrocode opened this issue Jun 21, 2021 · 3 comments
Closed

Comments

@nitrocode
Copy link

Nice set of modules. I was checking it out as I recently ran into this issue actions/setup-python#162. I realized that the Philips's modules also create an ASG and use Amazon Linux 2.

I looked at your workflows and they all use ubuntu-latest instead of self-hosted. Why not dogfood the runners for this public repo ?

@ingledl
Copy link

ingledl commented Jun 28, 2021

Because it's a public repo:

We recommend that you only use self-hosted runners with private repositories. This is because forks of your repository can potentially run dangerous code on your self-hosted runner machine by creating a pull request that executes the code in a workflow.

https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security-with-public-repositories

@nitrocode
Copy link
Author

Fascinating. This would be good to document in the README. If I was to add this in a PR, would it be accepted?

@npalm
Copy link
Member

npalm commented Jun 30, 2021

Please feel free to update the PR with this note. And indeed for that reason we not running on self-hostd but on public.

@npalm npalm closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants