Add follow_redirect/2 to Phoenix.ConnTest #5797
Merged
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds follow_redirect/2 to Phoenix.ConnTest. When testing complex redirect flows e.g a callback from an external source, then I found it as usefull as Phoenix.LiveViewTest.follow_redirect.
|
💚 💙 💜 💛 ❤️ |
|
I have to revert this because if conflicts with follow_redirect in LiveView. We probably need a separate name for it. |
josevalim
added a commit
that referenced
this pull request
Jun 18, 2024
This reverts commit 5d3dc22.
josevalim
added a commit
that referenced
this pull request
Jun 18, 2024
Couldn’t we unify both APIs and only compile certain functions if LiveView is available? |
osbre
pushed a commit
to osbre/phoenix
that referenced
this pull request
Nov 6, 2024
)" (phoenixframework#5849) This conflicts with follow_redirect in LiveView. Reverts phoenixframework#5797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds follow_redirect/2 to Phoenix.ConnTest.
When testing complex redirect flows e.g a callback from an external source, then I found it as usefull as Phoenix.LiveViewTest.follow_redirect.