Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cgi-path option #393

Open
fiskWasTaken opened this issue Jun 25, 2018 · 3 comments
Open

The cgi-path option #393

fiskWasTaken opened this issue Jun 25, 2018 · 3 comments
Assignees

Comments

@fiskWasTaken
Copy link
Contributor

fiskWasTaken commented Jun 25, 2018

Is there a reason to have this? I do not think there should be a situation where the PHP installation used for the master and slave processes is disparate. This leads to confusion with missing extensions between versions, etc.

The PHP installation should be determined from the master process, instead of being passed in as an option. If someone wants to use a different PHP installation, they should start the manager with it.

@andig
Copy link
Contributor

andig commented Jun 25, 2018 via email

@andig
Copy link
Contributor

andig commented Aug 24, 2018

ping @marcj is the cgi option still relevant? Doesn't feel like it since we're handling all connection through reactphp?

@marcj
Copy link
Member

marcj commented Aug 26, 2018

The workers need to be run with PHP-CGI, there's no way around it and there will never be if you're using native PHP session, cookie, http header stuff. The master process however can be started with the regular PHP binary. The question is actually a different one as I understood. The master and worker should not run with different PHP binaries, but the master should be started always with the cgi binary, which is then used for all workers as well, which basically destroys the cgi option. I'm ok with that, and also would suggest to print a fat warning when the master process is started without the cgi binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants