Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #502

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andreybolonin
Copy link
Contributor

@andreybolonin andreybolonin commented Dec 25, 2023

Closes #501

@bocharsky-bw
Copy link
Member

bocharsky-bw commented Dec 25, 2023

Thank you for this PR! Test failures look related, could you rebuild with the latest changes in master branch, I started using Composer v2 in #503 - hopefully it will fix most fails

@bocharsky-bw
Copy link
Member

OK, I rebase with master - now seems failures are related to this PR

@spiider8
Copy link

spiider8 commented Jan 8, 2024

Hi, how this PR looks? When wil it be done please? Thanks ;)

@bocharsky-bw
Copy link
Member

The problem is that this bundle depends on other bundles that do not have Symfony 7 support yet, e.g:

So to make this bundle trully support Symfony 7 - we need to add Symfony 7 support to the bundles mentioned above first, make releases for them, and finally merge this PR if tests pass.

I tried to quickly allow Symfony 7 support in those bundles, but as you can see tests failed there. Unfortunately, I don't have time yet to fix them, if anyone wants to be a volunteer to help fixing tests in those packages - please, let me know... or just create a new PR with proper fixes. As soon as we're green - I will be happy to review / merge and move it forward.

@byhaskell
Copy link

Hello. What is the current status?
I saw that there are recent changes in the named packages, do you need more help?

@rvanlaak
Copy link
Member

@byhaskell php-translation/extractor#172 (comment) currently the part where this is stuck.

@althaus
Copy link
Contributor

althaus commented Jan 31, 2024

What about a dropping the extractor and using Symfony's translation:extract command?

I've haven't checked what the extractor is doing, but it sounds that those two are doing similar things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for symfony 7.0
6 participants