Skip to content

Various executor config fixes #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2021
Merged

Various executor config fixes #880

merged 2 commits into from
Jul 18, 2021
+92 −51

Conversation

dantleech
Copy link
Member

@dantleech dantleech commented Jun 27, 2021 •
edited
Loading

There is lots about the executor configuration which does not work. This PR will fix #878 but also:

  • Executor for Before/After benchmark is overwritten by any custom Subject executor, meaning the tear down will use the last customized subject executor and not the benchmark executor as intended.
  • The executor used for a subject is always overwritten by the last subject's executor.
  • [bug] Cannot specify custom configuration for executors``` #878 Executor config from phpbench.json not used.

The Runner is in desparate need of refactoring 🙁

Sorry, something went wrong.

@dantleech dantleech changed the base branch from master to 1.0.x June 27, 2021 21:39
dantleech added a commit that referenced this pull request Jul 18, 2021
@dantleech
Fix configuration fixes #880

Verified

This commit was signed with the committer’s verified signature.
IvanGoncharov Ivan Goncharov
GPG key ID: 565A593B3E13C939
Verified
Learn about vigilant mode
5c2b02c
@dantleech dantleech force-pushed the gh-878-various-executor-config-fixes branch from 1f92c47 to 46ecfad Compare July 18, 2021 13:59
@dantleech
Failing test for subject overriding benchmark executor
41c5841 
FIX: Ensure that subject executor does not override benchmark executor

Subject benchmark can arbitrarily change the executor used to tear down
the benchmark

Failing test for running subjects with different executors

FIX bug with subject executors configurations overwriting eachother

Fix CS

Update barchart report example

Fix configuration fixes #880

Approved
@dantleech dantleech force-pushed the gh-878-various-executor-config-fixes branch from 46ecfad to 41c5841 Compare July 18, 2021 14:01
@dantleech dantleech merged commit b75605a into 1.0.x Jul 18, 2021
@dantleech dantleech deleted the gh-878-various-executor-config-fixes branch July 18, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Cannot specify custom configuration for executors```
1 participant
@dantleech