Skip to content

Parameters seem to be converted to strings when storing/retrieving #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dantleech opened this issue Dec 18, 2021 · 0 comments
Closed

Parameters seem to be converted to strings when storing/retrieving #959

dantleech opened this issue Dec 18, 2021 · 0 comments
Labels
bug

Comments

@dantleech
Copy link
Member

dantleech commented Dec 18, 2021 •
edited
Loading

When running a report from storage which uses the parameters in an expression, where the parameter values are integers:

(mode(partition['result_time_avg']) - first(partition['variant_params'][0])) as time

We get the error:

  Expected "PhpBench\Expression\Ast\NumberNode" but got "PhpBench\Expression\Ast\StringNode":  
                                                                                               
      (mode(partition[result_time_avg]) - first(partition[variant_params][0])) as time

The report is fine when running != storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dantleech