The result cache should still work if there are no composer or baseline files. #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Originated from: #1011
Breaking change: no
The result cache will generate cache data with 5 keys. One of those keys is
baselineHash
, which can benull
. However I usedisset (instead of
array_keys_exist
), to check if all keys were present. Ive changed this toarray_keys_exist
instead.Added testcase for the original problem.
Thanks @mvoelker for the investigation of the problem.