Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Undefined Variable Rule #497

Merged
merged 4 commits into from Aug 17, 2019
Merged

Implement Undefined Variable Rule #497

merged 4 commits into from Aug 17, 2019

Conversation

raa0121
Copy link
Contributor

@raa0121 raa0121 commented Jun 26, 2017 •
edited by ravage84

Closes #65
I wrote new module based on #64.

@ravage84 ravage84 added this to the 2.7.0 milestone Jun 26, 2017
@ravage84 ravage84 self-requested a review June 26, 2017 08:19
@ravage84 ravage84 self-assigned this Jun 26, 2017
@SurveyGizmoOfficial
Copy link

Would love to see this implemented!

@liaol
Copy link

liaol commented Nov 15, 2018 •
edited

It works. Thanks @raa0121
Hope for merging to master.

kylekatarnls
kylekatarnls reviewed Jun 18, 2019
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment •
edited by ravage84

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very good to me, but seems to not belong to UnusedCode ruleset to me.

@ravage84 ravage84 changed the title Support Undefined Variable #65 Support Undefined Variable Jun 25, 2019
@ravage84 ravage84 changed the title Support Undefined Variable Implement Undefined Variable Rule Jun 25, 2019
@ravage84 ravage84 modified the milestones: 2.7.0, 2.8.0 Jul 9, 2019
kylekatarnls
kylekatarnls previously approved these changes Jul 28, 2019
View reviewed changes
@kylekatarnls
Merge branch 'master' of https://github.com/phpmd/phpmd into add-unde…
c6a8eee 
…fined-variable

# Conflicts:
#	src/main/resources/rulesets/cleancode.xml
@tvbeek
Copy link
Member

tvbeek commented Aug 17, 2019

@raa0121 thanks for the PR.

@tvbeek tvbeek merged commit e401ec3 into phpmd:master Aug 17, 2019
@raa0121 raa0121 deleted the add-undefined-variable branch August 19, 2019 02:30
@raa0121
Copy link
Contributor Author

raa0121 commented Aug 19, 2019

thank you for merging.

@tvbeek tvbeek mentioned this pull request Oct 31, 2019
Closed
5 tasks
@tvbeek tvbeek mentioned this pull request Nov 8, 2019
Merged
@matweew matweew mentioned this pull request Dec 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvbeek tvbeek tvbeek approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

@ravage84 ravage84 Awaiting requested review from ravage84

Assignees

@ravage84 ravage84

Labels
Feature
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

[WIP] [GH-38] Implement undefined variable rule
6 participants
@raa0121 @SurveyGizmoOfficial @liaol @tvbeek @kylekatarnls @ravage84