Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new options to command-line interface #525

Merged
merged 1 commit into from Oct 15, 2017
Merged

Adding new options to command-line interface #525

merged 1 commit into from Oct 15, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2017

@ravage84 ravage84 added this to the 2.7.0 milestone Oct 12, 2017
ravage84
ravage84 requested changes Oct 12, 2017
View reviewed changes
Copy link
Member

@ravage84 ravage84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. Please reorder the mentioned options.

src/site/rst/documentation/index.rst Outdated
@@ -40,10 +40,10 @@ Command line options

- The command line interface also accepts the following optional arguments:

- ``--minimumpriority`` - The rule priority threshold; rules with lower
- ``--min-priority`` ``--minimum-priority`` ``--minimumpriority`` - The rule priority threshold; rules with lower
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have the original ones as first mentioned.

src/site/rst/documentation/index.rst Outdated
priority than they will not be used.

- ``--reportfile`` - Sends the report output to the specified file,
- ``--report-file`` ``--reportfile`` - Sends the report output to the specified file,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have the original one as first mentioned.

@ghost
Copy link
Author

ghost commented Oct 14, 2017

I reordered the options in the documentation.

@ravage84 ravage84 merged commit 71b52be into phpmd:master Oct 15, 2017
@ravage84
Copy link
Member

Thanks! 🍹

@ghost ghost deleted the new-cli-options branch October 18, 2017 14:11
@ghost
Copy link
Author

ghost commented Oct 18, 2017

Thanks for your work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ravage84