Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip DuplicatedArrayKey rule check, if there is no array key... #625

Merged
merged 1 commit into from Jul 10, 2019
Merged

Skip DuplicatedArrayKey rule check, if there is no array key... #625

merged 1 commit into from Jul 10, 2019

Conversation

ravage84
Copy link
Member

@ravage84 ravage84 commented Jul 8, 2019

... but just an array value

Extend test example to cover this case.

@ravage84
Skip DuplicatedArrayKey rule check, if there is no array key, just an…
c7479c6 
… array value

Extend test example to cover this case.
@ravage84 ravage84 added the Bug label Jul 8, 2019
@ravage84 ravage84 added this to the 2.7.0 milestone Jul 8, 2019
@ravage84 ravage84 requested a review from eeree July 8, 2019 23:12
kylekatarnls
kylekatarnls approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug confirmed, triggered with any double scalar value.

@ravage84 ravage84 modified the milestones: 2.7.0, 2.8.0 Jul 9, 2019
@tvbeek tvbeek merged commit 43d4ed0 into master Jul 10, 2019
@kylekatarnls kylekatarnls deleted the duplicate-array-key-checks-values branch July 10, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeree eeree eeree approved these changes

@tvbeek tvbeek tvbeek approved these changes

@roukmoute roukmoute roukmoute approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
Bug
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ravage84 @eeree @tvbeek @roukmoute @kylekatarnls