Allowing custom exclusion for StaticAccess by extending the class #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVaughn
approved these changes
Feb 25, 2020
kylekatarnls
approved these changes
Feb 25, 2020
|
Thanks! That's a nice extension we should try to apply to other rules. |
ondrejfuhrer
deleted the
ondrejfuhrer-static-access-allow-custom-exclusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature / refactoring
Breaking change: no
Description / Reason
In a project we need a custom exclusion rules for this rule. Looking at the code it doesn't allow easy extension so I would like to enable that.
Actions taken
Extracted exclusion into a protected function which enabled extending this class and customise the functionality.