Thorough Code Style Fixes #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly whitespace, PSR-2 violations fixed & doc blocks.
…rol keywords look like single words. https://www.php-fig.org/psr/psr-2/#51-if-elseif-else
…rol keywords look like single words. https://www.php-fig.org/psr/psr-2/#51-if-elseif-else
Mostly whitespace, PSR-2 violations fixed & doc blocks.
ravage84
commented
May 7, 2020
kylekatarnls
previously approved these changes
May 8, 2020
.../files/Rule/Design/EvalExpression/testRuleAppliesMultipleTimesToMethodWithEvalExpression.php
Outdated
Show resolved
Hide resolved
MarkVaughn
previously approved these changes
May 8, 2020
MarkVaughn
previously approved these changes
May 8, 2020
kylekatarnls
reviewed
May 8, 2020
...iles/Rule/Design/EvalExpression/testRuleAppliesMultipleTimesToFunctionWithEvalExpression.php
Outdated
Show resolved
Hide resolved
...iles/Rule/Design/ExitExpression/testRuleAppliesMultipleTimesToFunctionWithExitExpression.php
Outdated
Show resolved
Hide resolved
.../files/Rule/Design/ExitExpression/testRuleAppliesMultipleTimesToMethodWithExitExpression.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
kylekatarnls
approved these changes
May 11, 2020
MarkVaughn
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: refactoring (cleanup)
Issue: Resolves none
Breaking change: no
I executed the
Reformat codefunctionality of PhpStorm 2020.1 on our bin, source & tests folders.The very most of them are totally trivial stuff like:
Since PHPMD doesn't care about codestyle in the sense of formatting, these changes do not affect the tests.
I only had to adjust one test case as the violating lines in the test file changed due to the reformatting.
I hope we can merge this quickly, so new PRs can base upon this and won't have merge conflicts.
LTGM 🤑