Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "tool" property to main "pmd" tag in XML report #834

Merged
merged 2 commits into from Oct 18, 2020
Merged

Add "tool" property to main "pmd" tag in XML report #834

merged 2 commits into from Oct 18, 2020

Conversation

martzd
Copy link
Contributor

@martzd martzd commented Oct 5, 2020

Type: feature
Issue: Resolves #375
Breaking change: no

@kylekatarnls
Copy link
Member

Thanks.

It could be indeed useful. But then tests need to be updated accordingly.

@martzd
Copy link
Contributor Author

martzd commented Oct 5, 2020

@kylekatarnls I've fixed the tests

tvbeek
tvbeek approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@tvbeek tvbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and for updating the tests

@tvbeek tvbeek added the Output label Oct 6, 2020
@tvbeek tvbeek merged commit 98491e8 into phpmd:master Oct 18, 2020
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVaughn MarkVaughn MarkVaughn approved these changes

@tvbeek tvbeek tvbeek approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
Needs Tests Output
Milestone
2.x (unspecific)
Development

Successfully merging this pull request may close these issues.

unique identifier to distinguish from pmd
5 participants
@martzd @kylekatarnls @MarkVaughn @tvbeek @ravage84