adds checkstyle compatible renderer, suitable for cs2pr or reviewdog #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com> Update src/test/php/PHPMD/TextUI/CommandTest.php Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
- Also: declare a method showing equivalence between priority and severity
ffflabs
force-pushed
the
feature/checkstyle_renderer
branch
from
8c8ad12
to
5e8d195
Compare
kylekatarnls
reviewed
Jan 4, 2021
kylekatarnls
reviewed
Jan 4, 2021
- As phpmd is meant to run in a broad range of php versions,
we cannot rely on features that wouldn't run in PHP 5.4.x
- Violation fileName shoulnd't be modified. Any path canonicalization
needed by an external tool should be applied afterwards
Co-authored-by: Kyle <kylekatarnls@users.noreply.github.com>
kylekatarnls
previously approved these changes
Jan 7, 2021
kylekatarnls
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Breaking change: no
Adds a new Renderer for checkstyle output, in order to manage the outcome of phpmd, phpcs, psalm, phpstan and rector in a common format, suitable to make Github Actions annotate faults in your PR via the checks API (see CS2PR)
Please check this points before submitting your PR.