Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multiple triggers export/drop #18556

Open
liviuconcioiu opened this issue Jul 21, 2023 · 3 comments · May be fixed by #18999
Open

Improve multiple triggers export/drop #18556

liviuconcioiu opened this issue Jul 21, 2023 · 3 comments · May be fixed by #18999
Labels
affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete

Comments

@liviuconcioiu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Right now for each trigger exported/dropped, it makes a single request. If there are 100 triggers, to export/drop all of them or some of them it takes seconds/minutes (depending on connection speed).

21.07.2023_20.28.44_REC.mp4

Describe the solution you'd like

Export or Drop actions should be made in a single POST request.

Additional context

  • phpMyAdmin version: 5.2.2-dev, 6.0.0-dev
@williamdes
Copy link
Member

Thank you for the report!

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin good first issue affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Jul 21, 2023
@IAndreyI
Copy link
Contributor

Hello. I want to fix it. Where can I create my fix branche?

@liviuconcioiu
Copy link
Contributor Author

@IAndreyI you should target the master branch.

@IAndreyI IAndreyI mentioned this issue Nov 27, 2023
Closed
6 tasks
@IAndreyI IAndreyI mentioned this issue Feb 11, 2024
Closed
6 tasks
@IAndreyI IAndreyI linked a pull request Feb 19, 2024 that will close this issue
Open
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
No milestone
3 participants
@williamdes @liviuconcioiu @IAndreyI