New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add throw point for division #1280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it's impossible to narrow float range now This reverts commit 1223fca.
I'm too much out of context but would checking against PHP_FLOAT_EPSILON help with the float 0 detection? |
@herndlm |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#6349
Implemented throw point for zero value div/mod
DivisionByZeroError
.I didn't implemented it for
float
, because currently there is no way to narrow float value as non-zero float.I'm not satisfied enough with 01c2761
zero value
ConstantScalarType
would not be passed tocalculateFromScalars
because it's handled herephpstan-src/src/Analyser/MutatingScope.php
Lines 989 to 1022 in 55b9952
Although, this commit might not be redundant, because using
calculateFromScalars
in other places may causeDivisionByZeroError
.