Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support narrowing down via in_array with enum cases #1291

Merged
merged 1 commit into from May 9, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented May 5, 2022

Closes phpstan/phpstan#7176

I was wondering if there is a more generic / better way of fixing this. This one at least is the least invasive one I guess.

@herndlm herndlm changed the base branch from 1.7.x to 1.6.x May 5, 2022 17:45
@herndlm herndlm marked this pull request as ready for review May 5, 2022 17:51
@herndlm herndlm force-pushed the fix-7176 branch 4 times, most recently from 3b20724 to 693817a Compare May 5, 2022 19:11
@herndlm
Copy link
Contributor Author

herndlm commented May 5, 2022

I found the other in_array issues now. Looks like there will be one or two more PRs like this and maybe I could look into refactor this then. And, I guess, there was still something with impossible check hacks for in_array which now feels very related. Maybe it's time to look at that then :)

@ondrejmirtes
Copy link
Member

Thank you. in_array needs to be rethought completely, right now it's a buggy mess. It's a hard function to get right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants