Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip message to JSON error formatter #1727

Merged
merged 2 commits into from Oct 3, 2022
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 17, 2022

@staabm staabm force-pushed the json-tip branch 3 times, most recently from 72a2857 to 5a10897 Compare September 17, 2022 09:28
@staabm
Copy link
Contributor Author

staabm commented Sep 17, 2022

sorry for pushing over and over here, but for whatever reason the tests failling in CI do not fail for me locally :-/

@staabm staabm marked this pull request as ready for review September 17, 2022 09:34
@ondrejmirtes
Copy link
Member

The failures are feedback that this is a disrupting BC break for LevelsTestCase. Please unset the tip offset before saving/comparing the JSONs so that no changes are needed there.

@staabm staabm force-pushed the json-tip branch 3 times, most recently from b848599 to b5472a8 Compare September 22, 2022 10:21
@staabm staabm force-pushed the json-tip branch 2 times, most recently from a59ef7e to acd5c66 Compare October 3, 2022 06:50
@ondrejmirtes ondrejmirtes changed the title add tip-message to json error format Add tip message to JSON error formatter Oct 3, 2022
@ondrejmirtes ondrejmirtes merged commit 8657382 into phpstan:1.8.x Oct 3, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the json-tip branch October 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants