Improve TypeCombinator::reduceArrays()
perf with retained type compleness
#1741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for phpstan/phpstan#7666. This sort-of depends on #1666 (or a similar solution) to keep arrays with many
HasOffsetValueType
s more compact, which now do suffer from a perf loss.The complex test cases that this mostly covers have become a bit slower, but still very manageable.