Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IssetCheck/MutatingScope::issetCheck deviations and remove too early exits #1784

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Oct 2, 2022

While trying to check the deviations in the code that handles ArrayDimFetch I noticed the following things that I re-did in MutatingScope::issetCheck() because they were done at some point in IssetCheck

Additionally, I thought the early exit in the no block looked weird too and removed it as well since tests were green.

I hope this helps in removing duplications and I wanted to see if CI is also green..

@herndlm herndlm changed the base branch from 1.9.x to 1.8.x October 2, 2022 21:49
@herndlm herndlm force-pushed the reduce-isset-check-deviations-and-remove-too-early-exits branch from e6e37df to 1988d0d Compare October 2, 2022 21:49
@herndlm herndlm marked this pull request as ready for review October 2, 2022 21:57
@herndlm
Copy link
Contributor Author

herndlm commented Oct 3, 2022

Fyi I have a rough plan about re-usage of this code already that I'll be working on in the evening :)

@ondrejmirtes ondrejmirtes merged commit 1eb0d1b into phpstan:1.8.x Oct 3, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the reduce-isset-check-deviations-and-remove-too-early-exits branch October 3, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants