Remove IssetCheck/MutatingScope::issetCheck deviations and remove too early exits #1784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to check the deviations in the code that handles
ArrayDimFetch
I noticed the following things that I re-did inMutatingScope::issetCheck()
because they were done at some point inIssetCheck
Scope::isSpecified
was added additionally to the yes blockAdditionally, I thought the early exit in the no block looked weird too and removed it as well since tests were green.
I hope this helps in removing duplications and I wanted to see if CI is also green..