Make array access on possible false tolerant with isset #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedash95
force-pushed
the
fix-bug-8068
branch
from
5b21e40
to
6fd272b
Compare
Make array access tolerant with isset Fixes bug phpstan/phpstan#8068
ahmedash95
force-pushed
the
fix-bug-8068
branch
from
6fd272b
to
29de899
Compare
ondrejmirtes
requested changes
Oct 4, 2022
ondrejmirtes
changed the title
|
Thank you! |
rajyan
reviewed
Nov 18, 2022
Comment on lines
-114
to
-117
| [ | ||
| 'Cannot access offset \'a\' on array{a: 1, b: 1}|(Closure(): void).', | ||
| 258, | ||
| ], |
There was a problem hiding this comment.
Calling closure or object (without ArrayAccess) causes a fatal error, so this case shouldn't be ignored.
https://3v4l.org/lFcCq
I think it might be better to have another condition to the type, whether isOffestAccessible->no throws an fatal error or not.
This might lead to improvements in issues like phpstan/phpstan#8388
There was a problem hiding this comment.
It's better to open a new issue about this, comments on old merged PRs will get lost :)
There was a problem hiding this comment.
Thank you! Done phpstan/phpstan#8393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#8068.
Hey Ondrej,
As discussed in the bug. PHP is tolerant with
isset.The removed line
Cannot access offset \'a\' on array{a: 1, b: 1}|(Closure(): void).from the other test is reasonable because closure key access in isset would always be reported.appreciate your help on getting the fix for this one.