Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant_hassers: false not longer working in PHPStan 1.6.3 #270

Open
alexander-schranz opened this issue Apr 28, 2022 · 1 comment
Open

Comments

@alexander-schranz
Copy link
Contributor

I have the following configured:

parameters:
    symfony:
        constant_hassers: false

Since PHPStan 1.6.3 I'm now getting:

 ------ -------------------------------------------------------------------------------------------------
  Line   src/Sulu/Bundle/HttpCacheBundle/Tests/Unit/DependencyInjection/SuluHttpCacheExtensionTest.php
 ------ -------------------------------------------------------------------------------------------------
  100    Call to method PHPUnit\Framework\Assert::assertTrue() with false will always evaluate to false.
  101    Call to method PHPUnit\Framework\Assert::assertTrue() with false will always evaluate to false.
 ------ -------------------------------------------------------------------------------------------------

Which uses has to test if a service exist: https://github.com/sulu/sulu/blob/da963682357464af6dd15de88b565c3e2bd1a70c/src/Sulu/Bundle/HttpCacheBundle/Tests/Unit/DependencyInjection/SuluHttpCacheExtensionTest.php#L100-L101

Maybe it has todo with the change in: phpstan/phpstan-src@5c85200

@VincentLanglet
Copy link
Contributor

I think there is no test so far about this constantHasser config.
Might be worth to add some ; do you want to do it @alexander-schranz ?
It might help to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants