Extension access to attributes inside a trait

[spaze]

Hi,

I'd like to detect attributes inside a trait to compare it with a list of forbidden attributes (building a new feature for my disallowed calls extension).

I have this PHP file:

<?php
declare(strict_types = 1);

namespace Attributes;

#[AttributeClass1]
trait TraitWithAttributes
{

	#[AttributeClass2]
	private const TRAIT_CONST = true;

	#[AttributeClass3]
	private $bar;


	#[AttributeClass4]
	public function traitMethod(
		#[AttributeClass5]
		bool $param
	): void {
	}

}


class ClassWithTraitWithAttributes
{

	use TraitWithAttributes;

}

I'd like my extension to access those attributes inside the trait, but so far I'm failing at that.

My Rule implementation now has only this:

	public function getNodeType(): string
	{
		return Node::class;
	}

and

	public function processNode(Node $node, Scope $scope): array
	{
		var_dump($node::class);
		return [];

to see the nodes that I have access to:

string(21) "PHPStan\Node\FileNode"
string(28) "PhpParser\Node\Stmt\Declare_"
string(34) "PhpParser\Node\Stmt\DeclareDeclare"
string(29) "PhpParser\Node\Scalar\LNumber"
string(30) "PhpParser\Node\Stmt\Namespace_"
string(26) "PhpParser\Node\Stmt\Trait_"
string(26) "PhpParser\Node\Stmt\Class_"
string(24) "PHPStan\Node\InClassNode"
string(28) "PhpParser\Node\Stmt\TraitUse"
string(32) "PHPStan\Node\ClassPropertiesNode"
string(29) "PHPStan\Node\ClassMethodsNode"
string(31) "PHPStan\Node\ClassConstantsNode"

I'm analyzing the file in RuleTestCase with

	public function testRule(): void
	{
		$this->analyse([__DIR__ . '/../src/AttributesEverywhere.php'], [
			[
...

I can access the trait attribute AttributeClass1 with Trait_::$attrGroups but I can't get to AttributeClass2, AttributeClass3 etc. I don't see any handy nodes in the list above, I have even tried starting off the Trait_ node and the TraitUse node but can't just find the right way to do it.

The closest I got was to use Trait_::stmts but then I lose scope and have incorrect line numbers in the errors. I have checked the ClassMethodsNode virtual node, but there are no methods which makes sense. I have also read about the new-ish InTraitNode which looked promising but it's not processed.

I have tried both the latest 1.10.x, also the 1.11.x-dev versions but the list of nodes is the same. I'm running PHP 8.3.0. I have read https://phpstan.org/blog/how-phpstan-analyses-traits and hopefully understood that correctly.

When I analyze the file with phpstan.org/try, it flags the attribute classes as missing (obviously) https://phpstan.org/r/f5928f46-7bae-4c21-b85c-a88cdc66557d so there's seems to be a way but I can't find it.

I'm missing something, any hint, or help how can I access those attributes would be appreciated. Thanks!

[ondrejmirtes]

I figured out the mystery in your repo :) spaze/phpstan-disallowed-calls#226

[spaze]

Thank you, awesome! :-)