Errors that are ignored do not get handled correctly when the analysis runs in a Bitbucket pipeline.

[rensw90]

I'm busy integrating the PHPstan analysis in the pipeline. When I run the analysis on my local machine it doesn't find any errors, but when I run it in the pipeline it strangely finds 4 errors in 1 file.

These errors are added to the baseline and make it locally run without any errors:

$ignoreErrors[] = [
	'message' => '#^Call to an undefined method App\\\\Models\\\\User\\|Illuminate\\\\Database\\\\Eloquent\\\\Collection\\<int, App\\\\Models\\\\User\\>\\:\\:getKey\\(\\)\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/tests/Feature/Debug/SwitchUserTest.php',
];
$ignoreErrors[] = [
	'message' => '#^Parameter \\#1 \\$user of method App\\\\Util\\\\ChangeUser\\\\DevelopmentUserChangeTokenRepository\\:\\:generateToken\\(\\) expects App\\\\Models\\\\User, App\\\\Models\\\\User\\|Illuminate\\\\Database\\\\Eloquent\\\\Collection\\<int, App\\\\Models\\\\User\\> given\\.$#',
	'count' => 1,
	'path' => __DIR__ . '/tests/Feature/Debug/SwitchUserTest.php',
];

But when it's run in the pipeline these errors are found:

Line   [tests/Feature/Debug/SwitchUserTest.php](https://bitbucket.org/*company*/*repository*/src/020207b3cb00bd1f940bc3bbc84c2b4418286ed8/tests/Feature/Debug/SwitchUserTest.php)                                            
 ------ ---------------------------------------------------------------------------------- 
         Ignored error pattern #^Call to an undefined method                               
         App\\Models\\User\|Illuminate\\Database\\Eloquent\\Collection<int,                
         App\\Models\\User>\:\:getKey\(\)\.$# in path                                      
         /opt/atlassian/pipelines/agent/build/tests/Feature/Debug/SwitchUserTest.php       
         was not matched in reported errors.                                               
         Ignored error pattern #^Parameter \#1 \$user of method                            
         App\\Util\\ChangeUser\\DevelopmentUserChangeTokenRepository\:\:generateToken\(\)  
         expects App\\Models\\User,                                                        
         App\\Models\\User\|Illuminate\\Database\\Eloquent\\Collection<int,                
         App\\Models\\User> given\.$# in path                                              
         /opt/atlassian/pipelines/agent/build/tests/Feature/Debug/SwitchUserTest.php       
         was not matched in reported errors.                                               
  28     Parameter #1 $user of method                                                      
         App\Util\ChangeUser\ProductionUserChangeTokenRepository::generateToken()          
         expects App\Models\User,                                                          
         App\Models\User|Illuminate\Database\Eloquent\Collection<int,                      
         App\Models\User> given.                                                           
  30     Unreachable statement - code above always terminates.

This is the code that breaks the analysis:

namespace Tests\Feature\Debug;

use PHPUnit\Framework\Attributes\Test;
use App\Util\ChangeUser\UserChangeTokenRepositoryInterface;
use Database\Factories\UserFactory;
use Tests\Feature\FeatureTestCase;

final class SwitchUserTest extends FeatureTestCase
{
    private const SwitchUserPublicUrl = '/public/debug/switch_user/';

    #[Test]
    public function returns_not_found_when_missing_token(): void
    {
        $this->get(self::SwitchUserPublicUrl.'bad_token')
            ->assertNotFound();
    }

    #[Test]
    public function works_without_logged_in(): void
    {
        $user  = UserFactory::new()
            ->nonRepresentative()
            ->create();
        $token = $this->app->make(UserChangeTokenRepositoryInterface::class)
            ->generateToken($user);

        $this->assertGuest();
        $this->get(self::SwitchUserPublicUrl.$token)
            ->assertRedirect('/');
        $this->assertEquals($user->getKey(), auth()->id());
    }
}

Both analysis are run in PHP 8.3

Can anyone help me find out why this behaves differently? I really can't see why this file breaks.

[ondrejmirtes]

So something changes between your environments that causes different error messages to be reported. You should inspect why it's happening. First of all, you should make sure that composer.lock is commited to your repository and that you're NOT running composer update as part of the pipeline.

Other than that this article has some pointers you can look into: https://phpstan.org/user-guide/troubleshooting-types

[rensw90]

Thanks for your reply.

The composer.lock is committed and the composer update is not executed during the build. To make sure the environment is the same as my local environment, they both use the same docker image with the same config and extensions. The code itself is also the same. (same git branch)

So that is why I do not understand why the analysis results differ between the environments. The types itself should be ok, as my local environment does not have any problems with it.

The weird thing is, they are included in the baseline as shown in the first code snippet. This makes my local environment ignore them. When it runs in the pipeline the warnings still occur even though they are in the baseline (as shown in the second code snippet)