Assigning new empty SplObjectStorage

[uuf6429]

I'm getting errors when initialising a readonly SplObjectStorage property typed as a generic with specific key/val type:
https://phpstan.org/r/b49a9c75-11b1-40c3-b4d3-f86fff30d9bd

I just saw that this relates to #5810, so I didn't open a bug report.

Interestingly, from a practical point of view, the last example is actually the riskiest one, since in any case, there are no real assertions that the passed parameter is correct (whereas an empty SplObjectStorage defined in the class is guaranteed to be safe).

Am I missing something? 🤔

[ondrejmirtes]

Last example (DictionaryD_no_defaults) isn't risky. There's no error, you're simply describing what's allowed to be passed into the constructor.

When you do new DictionaryD_no_defaults(), that's when you'll get the error.

[ondrejmirtes]

And about the other errors: we'll be able to get rid of them once this suggestion is implemented #6732 (comment)

[uuf6429]

I meant practically riskier since it's the only one that specifically requires a parameter.

Looking at that issue title, no wonder I missed it. 😄

Is the following the only solution at the moment?
https://phpstan.org/r/754ace11-8bdc-43be-b6f0-e47905d1de2f

[uuf6429]

Is the following the only solution at the moment?

Actually never mind, in this case I can actually avoid passing as a parameter.

Thanks again!

[ondrejmirtes]

Hey, I realized that DictionaryD_no_defaults should also lead to declaration error: https://3v4l.org/RQVHb

So I implemented that: phpstan/phpstan-src@b2177e3

[uuf6429]

Well, that was a happy accident. 😄
Thanks!