Generics in repository pattern problem

[PingusPepan]

Hello,
I'm trying to understand why phpstan is not accepting concrete implementations of my repository classes in DI

Here is a simplified example: https://phpstan.org/r/cc252630-26ed-4fda-ae33-53237020433e

I'd expect that by using @extends I'll be able to use concrete repository classes in DI and elsewhere but that is not the case. I'm still using it because I need the typehints from IDE for the concrete repositories but it's not the best feeling having errors everywhere 🙁

If I use it with AbstractRepository then it's missing all the methods from the final repository: https://phpstan.org/r/51c111fd-cf02-44cf-a2ca-eb8659267b3e

What am I doing wrong?

[ondrejmirtes]

PHPStan cannot understand that $repositoryManager->getRepositoryByEntity(Product::class) will return ProductRepository. This information isn't encoded anywhere.

You can use a dynamic return type extension in order to infer that: https://phpstan.org/developing-extensions/dynamic-return-type-extensions

phpstan-doctrine does something similar because it faces the same challenge.

[PingusPepan]

Thanks, I'll try that
I was expecting that it's going to work because ProductRepository is extending AbstractRepository and thought that phpstan would be able to connect the two together based on the @extends but when I tried with dumpType it only saw ProductRepository