Unable to get PHPStan to warn about missing try/catch blocks

[Jemt]

Hi,

I'm unable to get PHPStan 1.10.67 to fail when function calls, which throws checked exceptions, are not wrapped in try/catch blocks.

Here is my test code:

~/phpstan.neon
~/Server/TestPhpStan.php
~/Server/vendor/* (composer packages, including PHPStan)

I use the following configuration (~/phpstan.neon):

includes:
  - Server/vendor/phpstan/phpstan/conf/bleedingEdge.neon
  - Server/vendor/phpstan/phpstan-strict-rules/rules.neon
parameters:
  level: max
  paths:
    - Server
  excludePaths:
    - Server/vendor
  exceptions:
    check:
      missingCheckedExceptionInThrows: true
      tooWideThrowType: true
    checkedExceptionClasses:
      - 'Exception'

I'm testing using the following code (~/Server/TestPhpStan.php):

<?php

/** @throws Exception */
function multiplyByTwo(int $x): int
{
	if (time() > 1238)
	{
		throw new Exception("Oh no!");
	}

	return $x * 2;
}

echo multiplyByTwo(4);

?>

I run PHPStan on the command line from the root of my project where phpstan.neon is located:

php Server/vendor/phpstan/phpstan/phpstan.phar analyse --configuration=phpstan.neon --no-interaction --memory-limit=1G Server/TestPhpStan.php

The output result: [OK] No errors

Version check php Server/vendor/phpstan/phpstan/phpstan.phar --version returns PHPStan - PHP Static Analysis Tool 1.10.67

PHP version (php -v) is:

PHP 8.0.24 (cli) (built: Oct 20 2022 18:20:43) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.24, Copyright (c) Zend Technologies
    with Xdebug v3.1.1, Copyright (c) 2002-2021, by Derick Rethans

Can someone point me in the right direction here? What am I missing?

-- Thanks a lot :-)

[ondrejmirtes]

You mean to get an error for echo multiplyByTwo(4); when called outside of any function or method? There currently isn't any rule for that in PHPStan.

I recommend you to wrap all your code in functions and classes.

[ondrejmirtes]

I see where the confusion might come from. Exceptions are divided into two categories: checked and unchecked. All exceptions are checked by default.

But out of the box PHPStan doesn’t act upon checked exceptions. You need to turn on the parameters described in the article in order to have errors reported.

[Jemt]

I see. Thank you very much for clarifying 🙏😊 This project is awesome 😊

[Jemt]

@ondrejmirtes It seems anonymous functions are not being checked. Am I missing something here too? Or is this related to #3770 and therefore something that is work in progress ?

<?php

class Executor
{
	public static function Invoke(Callable $cb): void
	{
		$cb();
	}
}

class Test
{
	/** @throws Exception */
	public static function MultiplyByTwo(int $x): int
	{
		if (time() > 1238)
		{
			throw new Exception("Oh no!");
		}

		return $x * 2;
	}
}

function performTest(): void
{
	Test::MultiplyByTwo(2); // PHPStan: Function performTest() throws checked exception Exception but it's missing from the PHPDoc @throws tag

	Executor::Invoke(function()
	{
		Test::MultiplyByTwo(2); // PHPStan: No warning at all
	});
}

performTest();

?>

[ondrejmirtes]

Anonymous functions are not checked either because they do not support PHPDocs.

[Jemt]

Okay, thanks again @ondrejmirtes - much appreciate 😊